Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
urlutil: provide some information about "bad url" when processing `pushurl`
authorPierre-Yves David <pierre-yves.david@octobus.net>
Fri, 16 Apr 2021 00:16:43 +0200
changeset 47276 9cc9b4a25248
parent 47275 ba673c821b9d
child 47277 ed0d54b20c5b
urlutil: provide some information about "bad url" when processing `pushurl` It appears pushurl only support `<proto>://` entries. This is not obvious and can lead to obscure error. We make the error less obscure as a start.. Differential Revision: https://phab.mercurial-scm.org/D10455
mercurial/utils/urlutil.py file | annotate | diff | comparison | revisions
tests/test-paths.t file | annotate | diff | comparison | revisions 
--- a/mercurial/utils/urlutil.py	Sun Apr 11 19:19:34 2021 +0200
+++ b/mercurial/utils/urlutil.py	Fri Apr 16 00:16:43 2021 +0200
@@ -742,7 +742,9 @@
     u = url(value)
     # Actually require a URL.
     if not u.scheme:
-        ui.warn(_(b'(paths.%s:pushurl not a URL; ignoring)\n') % path.name)
+        msg = _(b'(paths.%s:pushurl not a URL; ignoring: "%s")\n')
+        msg %= (path.name, value)
+        ui.warn(msg)
         return None
 
     # Don't support the #foo syntax in the push URL to declare branch to
--- a/tests/test-paths.t	Sun Apr 11 19:19:34 2021 +0200
+++ b/tests/test-paths.t	Fri Apr 16 00:16:43 2021 +0200
@@ -175,7 +175,7 @@
   > EOF
 
   $ hg paths
-  (paths.default:pushurl not a URL; ignoring)
+  (paths.default:pushurl not a URL; ignoring: "/not/a/url")
   default = /path/to/nothing
 
 #fragment is not allowed in :pushurl
Mercurial