Mercurial > hg

changeset 25212:a39c35e8e559

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: reintroduce str.format() ban for 3.x porting In their infinite wisdom, the Python maintainers stripped bytes of its % and format() methods for 3.x. They've now added % back to 3.5, but format() is still missing. Since we don't have any particular need for it, we should keep avoiding it.
author Matt Mackall <mpm@selenic.com>
date Tue, 19 May 2015 08:41:04 -0500
parents 22f4ce49044d
children 08a8e9da0ae7
files contrib/check-code.py
diffstat 1 files changed, 1 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/contrib/check-code.py	Mon May 18 23:43:36 2015 -0500
+++ b/contrib/check-code.py	Tue May 19 08:41:04 2015 -0500
@@ -239,6 +239,7 @@
 #    (r'in range\(', "use xrange"),
 #    (r'^\s*print\s+', "avoid using print in core and extensions"),
     (r'[\x80-\xff]', "non-ASCII character literal"),
+    (r'("\')\.format\(', "str.format() has no bytes counterpart, use %"),
     (r'^\s*(%s)\s\s' % '|'.join(keyword.kwlist),
      "gratuitous whitespace after Python keyword"),
     (r'([\(\[][ \t]\S)|(\S[ \t][\)\]])', "gratuitous whitespace in () or []"),