verify: update comment to say that lfs doesn't need fulltext to check renames
authorMatt Harbison <matt_harbison@yahoo.com>
Sun, 22 Dec 2019 00:47:33 -0500
changeset 43956 a447efd991b9
parent 43955 75ec46c63657
child 43957 7c3118b9a9db
verify: update comment to say that lfs doesn't need fulltext to check renames The reason is that `filelog.renamed()` indirectly calls `filelog.revision()`, which is what accesses the full text. However, LFS wraps `filelog.renamed()` and completely handles the case where an LFS blob is in play by using rawdata. I've got a test to demonstrate that this is the case, and prevent regressions. But the `skipread` flag is set on all lfs revisions when using `--no-lfs`, regardless of whether or not the blobs are local. Just above this, that flag is consulted, causing the rename checks to be skipped. That will need to be loosened up first. Differential Revision: https://phab.mercurial-scm.org/D7709
mercurial/verify.py
--- a/mercurial/verify.py	Wed Dec 18 13:30:48 2019 -0800
+++ b/mercurial/verify.py	Sun Dec 22 00:47:33 2019 -0500
@@ -565,8 +565,9 @@
 
                 # check renames
                 try:
-                    # This requires resolving fulltext (at least on revlogs). We
-                    # may want ``verifyintegrity()`` to pass a set of nodes with
+                    # This requires resolving fulltext (at least on revlogs,
+                    # though not with LFS revisions). We may want
+                    # ``verifyintegrity()`` to pass a set of nodes with
                     # rename metadata as an optimization.
                     rp = fl.renamed(n)
                     if rp: