Mercurial > hg
changeset 34642:a679aa582d8d
check-code: forbid platform.system()
See the previous patches for the reason.
Differential Revision: https://phab.mercurial-scm.org/D1021
| author | Jun Wu <quark@fb.com> |
|---|---|
| date | Wed, 11 Oct 2017 17:42:57 -0700 |
| parents | bb6544b1c56e |
| children | f42dec9c976e |
| files | contrib/check-code.py |
| diffstat | 1 files changed, 1 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/contrib/check-code.py Wed Oct 11 17:42:35 2017 -0700 +++ b/contrib/check-code.py Wed Oct 11 17:42:57 2017 -0700 @@ -362,6 +362,7 @@ (r'\.next\(\)', "don't use .next(), use next(...)"), (r'([a-z]*).revision\(\1\.node\(', "don't convert rev to node before passing to revision(nodeorrev)"), + (r'platform\.system\(\)', "don't use platform.system(), use pycompat"), # rules depending on implementation of repquote() (r' x+[xpqo%APM][\'"]\n\s+[\'"]x',