log: remove unused argument from _makerevset()
authorYuya Nishihara <yuya@tcha.org>
Sat, 12 Sep 2020 16:19:01 +0900
changeset 45564 a717de1cb624
parent 45563 142f0dcf90d0
child 45565 c1d0f83d62c4
log: remove unused argument from _makerevset() I want to make getrevs() reusable for other commands, but the dependency graph of this getrevs() function is a mess. Let's minimize it first.
mercurial/logcmdutil.py
tests/printrevset.py
--- a/mercurial/logcmdutil.py	Sat Sep 12 16:11:10 2020 +0900
+++ b/mercurial/logcmdutil.py	Sat Sep 12 16:19:01 2020 +0900
@@ -800,7 +800,7 @@
 }
 
 
-def _makerevset(repo, match, pats, slowpath, opts):
+def _makerevset(repo, pats, slowpath, opts):
     """Return a revset string built from log options and file patterns"""
     opts = dict(opts)
     # follow or not follow?
@@ -896,7 +896,7 @@
         def filematcher(ctx):
             return match
 
-    expr = _makerevset(repo, match, pats, slowpath, opts)
+    expr = _makerevset(repo, pats, slowpath, opts)
     if opts.get(b'graph'):
         if repo.ui.configbool(b'experimental', b'log.topo'):
             if not revs.istopo():
--- a/tests/printrevset.py	Sat Sep 12 16:11:10 2020 +0900
+++ b/tests/printrevset.py	Sat Sep 12 16:19:01 2020 +0900
@@ -16,7 +16,7 @@
     if not revs:
         return None
     match, pats, slowpath = logcmdutil._makematcher(repo, revs, pats, opts)
-    return logcmdutil._makerevset(repo, match, pats, slowpath, opts)
+    return logcmdutil._makerevset(repo, pats, slowpath, opts)
 
 
 def uisetup(ui):