Mercurial > hg

changeset 13076:a861c7155f09

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: single check for Python keywords used as a function This replaces the specific checks for del/and/or/not/except and additionally checks other Python keywords.
author Thomas Arendsen Hein <thomas@jtah.de>
date Fri, 03 Dec 2010 12:04:31 +0100
parents d73c3034deee
children 6b8d2ee24ce2
files contrib/check-code.py
diffstat 1 files changed, 2 insertions(+), 5 deletions(-) [+]
line wrap: on
line diff
--- a/contrib/check-code.py	Fri Dec 03 11:30:45 2010 +0100
+++ b/contrib/check-code.py	Fri Dec 03 12:04:31 2010 +0100
@@ -119,11 +119,8 @@
     (r'^\s*(if|while|def|class|except|try)\s[^[]*:\s*[^\]#\s]+',
      "linebreak after :"),
     (r'class\s[^(]:', "old-style class, use class foo(object)"),
-    (r'^\s+del\(', "del isn't a function"),
-    (r'\band\(', "and isn't a function"),
-    (r'\bor\(', "or isn't a function"),
-    (r'\bnot\(', "not isn't a function"),
-    (r'^\s+except\(', "except isn't a function"),
+    (r'\b(%s)\(' % '|'.join(keyword.kwlist),
+     "Python keyword is not a function"),
     (r',]', "unneeded trailing ',' in list"),
 #    (r'class\s[A-Z][^\(]*\((?!Exception)',
 #     "don't capitalize non-exception classes"),