Mercurial > hg
changeset 18762:a91387a37f05
check-code: do not prepend "warning" to a failure message
The prefix has not been removed when this check changed from a warning to a
failure.
| author | Simon Heimberg <simohe@besonet.ch> |
|---|---|
| date | Sat, 09 Mar 2013 22:14:46 +0100 |
| parents | 8cc8715b3603 |
| children | eeafab2f58f6 |
| files | contrib/check-code.py tests/test-check-code.t |
| diffstat | 2 files changed, 5 insertions(+), 5 deletions(-) [+] |
line wrap: on
line diff
--- a/contrib/check-code.py Sat Mar 09 16:09:27 2013 -0800 +++ b/contrib/check-code.py Sat Mar 09 22:14:46 2013 +0100 @@ -216,7 +216,7 @@ (r'(?i)descendent', "the proper spelling is descendAnt"), (r'\.debug\(\_', "don't mark debug messages for translation"), (r'\.strip\(\)\.split\(\)', "no need to strip before splitting"), - (r'^\s*except\s*:', "warning: naked except clause", r'#.*re-raises'), + (r'^\s*except\s*:', "naked except clause", r'#.*re-raises'), (r':\n( )*( ){1,3}[^ ]', "must indent 4 spaces"), (r'ui\.(status|progress|write|note|warn)\([\'\"]x', "missing _() in ui message (use () to hide false-positives)"),
--- a/tests/test-check-code.t Sat Mar 09 16:09:27 2013 -0800 +++ b/tests/test-check-code.t Sat Mar 09 22:14:46 2013 +0100 @@ -163,13 +163,13 @@ object comparison with literal [1] - $ cat > warning.py <<EOF + $ cat > for-nolineno.py <<EOF > except: > EOF - $ "$check_code" warning.py --warning --nolineno - warning.py:0: + $ "$check_code" for-nolineno.py --nolineno + for-nolineno.py:0: > except: - warning: naked except clause + naked except clause [1] $ cat > raise-format.py <<EOF