ui: adjust Windows workaround to new _readline() code
authorYuya Nishihara <yuya@tcha.org>
Tue, 06 Mar 2018 02:42:37 -0600
changeset 36796 aa0fc12743c7
parent 36795 9b513888ea23
child 36797 d4c760c997cd
ui: adjust Windows workaround to new _readline() code It's only needed when rawinput() is called. Also made it Py3 compatible.
mercurial/ui.py
--- a/mercurial/ui.py	Tue Mar 06 02:38:53 2018 -0600
+++ b/mercurial/ui.py	Tue Mar 06 02:42:37 2018 -0600
@@ -1286,6 +1286,10 @@
         with self.timeblockedsection('stdio'):
             if usereadline:
                 line = encoding.strtolocal(pycompat.rawinput(r' '))
+                # When stdin is in binary mode on Windows, it can cause
+                # raw_input() to emit an extra trailing carriage return
+                if pycompat.oslinesep == b'\r\n' and line.endswith(b'\r'):
+                    line = line[:-1]
             else:
                 self.fout.write(b' ')
                 self.fout.flush()
@@ -1295,10 +1299,6 @@
                 if line.endswith(pycompat.oslinesep):
                     line = line[:-len(pycompat.oslinesep)]
 
-        # When stdin is in binary mode on Windows, it can cause
-        # raw_input() to emit an extra trailing carriage return
-        if pycompat.oslinesep == '\r\n' and line and line[-1] == '\r':
-            line = line[:-1]
         return line
 
     def prompt(self, msg, default="y"):