safehasattr: pass attribute name as string instead of bytes
authorPierre-Yves David <pierre-yves.david@octobus.net>
Thu, 02 Feb 2023 17:28:07 +0100
changeset 50582 b23b3ef38ba1
parent 50581 35b274cba81d
child 50583 833a4e881a7a
safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage.
mercurial/httppeer.py
--- a/mercurial/httppeer.py	Thu Feb 02 17:27:58 2023 +0100
+++ b/mercurial/httppeer.py	Thu Feb 02 17:28:07 2023 +0100
@@ -180,7 +180,7 @@
     qs = b'?%s' % urlreq.urlencode(q)
     cu = b"%s%s" % (repobaseurl, qs)
     size = 0
-    if util.safehasattr(data, b'length'):
+    if util.safehasattr(data, 'length'):
         size = data.length
     elif data is not None:
         size = len(data)