bundle2: relax the condition to update transaction.hookargs
authorYuya Nishihara <yuya@tcha.org>
Sun, 13 Aug 2017 11:10:35 +0900
changeset 33810 b3a41f4d837b
parent 33809 1bf5c5507614
child 33811 dabe1f11ae3a
bundle2: relax the condition to update transaction.hookargs This is just a micro optimization. If hookargs is empty, nothing should be necessary.
mercurial/bundle2.py
--- a/mercurial/bundle2.py	Sun Aug 13 11:05:56 2017 +0900
+++ b/mercurial/bundle2.py	Sun Aug 13 11:10:35 2017 +0900
@@ -304,15 +304,15 @@
     def gettransaction(self):
         transaction = self._gettransaction()
 
-        if self.hookargs is not None:
+        if self.hookargs:
             # the ones added to the transaction supercede those added
             # to the operation.
             self.hookargs.update(transaction.hookargs)
             transaction.hookargs = self.hookargs
 
-            # mark the hookargs as flushed.  further attempts to add to
-            # hookargs will result in an abort.
-            self.hookargs = None
+        # mark the hookargs as flushed.  further attempts to add to
+        # hookargs will result in an abort.
+        self.hookargs = None
 
         return transaction