dirstate-item: drop the legacy new_added constructor
Nobody is calling it anymore. Its purposes has been filled.
Differential Revision: https://phab.mercurial-scm.org/D11601
--- a/mercurial/cext/parsers.c Fri Oct 01 09:15:03 2021 +0200
+++ b/mercurial/cext/parsers.c Fri Oct 01 09:16:53 2021 +0200
@@ -347,23 +347,6 @@
return (PyObject *)dirstate_item_from_v1_data(state, mode, size, mtime);
};
-/* constructor to help legacy API to build a new "added" item
-
-Should eventually be removed */
-static PyObject *dirstate_item_new_added(PyTypeObject *subtype)
-{
- dirstateItemObject *t;
- t = (dirstateItemObject *)subtype->tp_alloc(subtype, 1);
- if (!t) {
- return NULL;
- }
- t->flags = dirstate_flag_wc_tracked;
- t->mode = 0;
- t->size = 0;
- t->mtime = 0;
- return (PyObject *)t;
-};
-
/* constructor to help legacy API to build a new "from_p2" item
Should eventually be removed */
@@ -492,9 +475,6 @@
"True if the stored mtime would be ambiguous with the current time"},
{"from_v1_data", (PyCFunction)dirstate_item_from_v1_meth,
METH_VARARGS | METH_CLASS, "build a new DirstateItem object from V1 data"},
- {"new_added", (PyCFunction)dirstate_item_new_added,
- METH_NOARGS | METH_CLASS,
- "constructor to help legacy API to build a new \"added\" item"},
{"new_from_p2", (PyCFunction)dirstate_item_new_from_p2,
METH_NOARGS | METH_CLASS,
"constructor to help legacy API to build a new \"from_p2\" item"},
--- a/mercurial/pure/parsers.py Fri Oct 01 09:15:03 2021 +0200
+++ b/mercurial/pure/parsers.py Fri Oct 01 09:16:53 2021 +0200
@@ -109,14 +109,6 @@
self._mtime = parentfiledata[2]
@classmethod
- def new_added(cls):
- """constructor to help legacy API to build a new "added" item
-
- Should eventually be removed
- """
- return cls(wc_tracked=True)
-
- @classmethod
def new_from_p2(cls):
"""constructor to help legacy API to build a new "from_p2" item
--- a/rust/hg-core/src/dirstate/entry.rs Fri Oct 01 09:15:03 2021 +0200
+++ b/rust/hg-core/src/dirstate/entry.rs Fri Oct 01 09:16:53 2021 +0200
@@ -125,14 +125,6 @@
}
}
- pub fn new_added() -> Self {
- Self {
- flags: Flags::WDIR_TRACKED,
- mode_size: None,
- mtime: None,
- }
- }
-
pub fn new_normal(mode: i32, size: i32, mtime: i32) -> Self {
Self {
flags: Flags::WDIR_TRACKED | Flags::P1_TRACKED,
--- a/rust/hg-cpython/src/dirstate/item.rs Fri Oct 01 09:15:03 2021 +0200
+++ b/rust/hg-cpython/src/dirstate/item.rs Fri Oct 01 09:16:53 2021 +0200
@@ -139,12 +139,6 @@
}
@classmethod
- def new_added(_cls) -> PyResult<Self> {
- let entry = DirstateEntry::new_added();
- DirstateItem::create_instance(py, Cell::new(entry))
- }
-
- @classmethod
def new_from_p2(_cls) -> PyResult<Self> {
let entry = DirstateEntry::new_from_p2();
DirstateItem::create_instance(py, Cell::new(entry))