check-code: make it possible to ignore the PWD check in some situation stable
authorPierre-Yves David <pierre-yves.david@octobus.net>
Fri, 17 Sep 2021 21:04:17 +0200
branchstable
changeset 47979 b84fe613de33
parent 47978 bad66df931b5
child 47980 1941064d3713
check-code: make it possible to ignore the PWD check in some situation The check-code script does not motivate the banning of $PWD so I am not sure what it is about. And I will needs to use the env variable in the next tests. So I am adding a way to make an exception. Differential Revision: https://phab.mercurial-scm.org/D11450
contrib/check-code.py
--- a/contrib/check-code.py	Fri Sep 17 14:05:56 2021 +0200
+++ b/contrib/check-code.py	Fri Sep 17 21:04:17 2021 +0200
@@ -195,7 +195,7 @@
     [
         (r'^function', "don't use 'function', use old style"),
         (r'^diff.*-\w*N', "don't use 'diff -N'"),
-        (r'\$PWD|\${PWD}', "don't use $PWD, use `pwd`"),
+        (r'\$PWD|\${PWD}', "don't use $PWD, use `pwd`", "no-pwd-check"),
         (r'^([^"\'\n]|("[^"\n]*")|(\'[^\'\n]*\'))*\^', "^ must be quoted"),
         (r'kill (`|\$\()', "don't use kill, use killdaemons.py"),
     ],