Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
check-code: warn about naked except clauses
authorIdan Kamara <idankk86@gmail.com>
Sat, 23 Apr 2011 00:52:21 +0300
changeset 14005 bb391e0515ba
parent 14004 97ed99d1f419
child 14006 a395575691a6
check-code: warn about naked except clauses
contrib/check-code.py file | annotate | diff | comparison | revisions 
--- a/contrib/check-code.py	Sat Apr 23 00:51:25 2011 +0300
+++ b/contrib/check-code.py	Sat Apr 23 00:52:21 2011 +0300
@@ -150,6 +150,7 @@
     (r'[^+=*!<>&| -](\s=|=\s)[^= ]',
      "wrong whitespace around ="),
     (r'raise Exception', "don't raise generic exceptions"),
+    (r'^\s*except:$', "warning: naked except clause"),
     (r'ui\.(status|progress|write|note|warn)\([\'\"]x',
      "warning: unwrapped ui message"),
     (r' is\s+(not\s+)?["\'0-9-]', "object comparison with literal"),
Mercurial