Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
repoview: fix conditional around unserved changesets
authorPierre-Yves David <pierre-yves.david@octobus.net>
Sat, 13 Apr 2019 20:57:50 +0200
changeset 42125 bc15e37ecc16
parent 42124 d6437f414437
child 42126 ef0e3cc684b3
repoview: fix conditional around unserved changesets The conditional could lead to wrong computation since we have more unserved changesets than just the "secret" phase. In addition, now that we have efficient caching of phased changesets, we don't need the conditional anymore.
mercurial/repoview.py file | annotate | diff | comparison | revisions 
--- a/mercurial/repoview.py	Fri Apr 05 16:05:20 2019 +0300
+++ b/mercurial/repoview.py	Sat Apr 13 20:57:50 2019 +0200
@@ -93,8 +93,8 @@
     assert not repo.changelog.filteredrevs
     # fast path in simple case to avoid impact of non optimised code
     hiddens = filterrevs(repo, 'visible')
-    if phases.hassecret(repo):
-        secrets = repo._phasecache.getrevset(repo, phases.remotehiddenphases)
+    secrets = repo._phasecache.getrevset(repo, phases.remotehiddenphases)
+    if secrets:
         return frozenset(hiddens | frozenset(secrets))
     else:
         return hiddens
Mercurial