Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
mmap: only use mmap to read rev-branch-cache data if it is safe stable
authorPierre-Yves David <pierre-yves.david@octobus.net>
Wed, 03 Jul 2024 12:31:21 +0200
branchstable
changeset 51654 c0e30a019ce1
parent 51653 d6c895e4adc4
child 51655 8e24f4f86ba8
mmap: only use mmap to read rev-branch-cache data if it is safe Cf `is_mmap_safe` docstring.
mercurial/branchmap.py file | annotate | diff | comparison | revisions 
--- a/mercurial/branchmap.py	Wed Jul 03 12:26:57 2024 +0200
+++ b/mercurial/branchmap.py	Wed Jul 03 12:31:21 2024 +0200
@@ -1213,11 +1213,12 @@
 
         if self._names:
             try:
-                if repo.ui.configbool(b'storage', b'revbranchcache.mmap'):
-                    with repo.cachevfs(_rbcrevs) as fp:
+                usemmap = repo.ui.configbool(b'storage', b'revbranchcache.mmap')
+                with repo.cachevfs(_rbcrevs) as fp:
+                    if usemmap and repo.cachevfs.is_mmap_safe(_rbcrevs):
                         data = util.buffer(util.mmapread(fp))
-                else:
-                    data = repo.cachevfs.read(_rbcrevs)
+                    else:
+                        data = fp.read()
                 self._rbcrevs = rbcrevs(data)
             except (IOError, OSError) as inst:
                 repo.ui.debug(
Mercurial