localrepo: fix bugs in branchheads and add docstring
- The call to reverse() reversed the list in place in the global branchmap.
- The nodesbetween function doesn't preserve ordering.
--- a/mercurial/localrepo.py Wed Sep 23 15:36:51 2009 +0200
+++ b/mercurial/localrepo.py Wed Sep 23 15:51:36 2009 +0200
@@ -1183,17 +1183,24 @@
return [n for (r, n) in sorted(heads)]
def branchheads(self, branch=None, start=None, closed=False):
+ '''return a (possibly filtered) list of heads for the given branch
+
+ Heads are returned in topological order, from newest to oldest.
+ If branch is None, use the dirstate branch.
+ If start is not None, return only heads reachable from start.
+ If closed is True, return heads that are marked as closed as well.
+ '''
if branch is None:
branch = self[None].branch()
branches = self.branchmap()
if branch not in branches:
return []
- bheads = branches[branch]
# the cache returns heads ordered lowest to highest
- bheads.reverse()
+ bheads = list(reversed(branches[branch]))
if start is not None:
# filter out the heads that cannot be reached from startrev
- bheads = self.changelog.nodesbetween([start], bheads)[2]
+ fbheads = set(self.changelog.nodesbetween([start], bheads)[2])
+ bheads = [h for h in bheads if h in fbheads]
if not closed:
bheads = [h for h in bheads if
('close' not in self.changelog.read(h)[5])]
--- a/tests/test-bheads.out Wed Sep 23 15:36:51 2009 +0200
+++ b/tests/test-bheads.out Wed Sep 23 15:51:36 2009 +0200
@@ -68,8 +68,8 @@
3: Adding b branch head 1
0
-------
+6: Merging b branch head 2 and b branch head 3
3: Adding b branch head 1
-6: Merging b branch head 2 and b branch head 3
0
-------
no changes on branch b containing . are reachable from 7