Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
contrib: ban $RANDOM using check-code
authorAugie Fackler <augie@google.com>
Tue, 13 Feb 2018 18:00:59 -0500
changeset 36164 c38e9248f531
parent 36163 068f520754ca
child 36165 53fe5a1a92bd
contrib: ban $RANDOM using check-code Differential Revision: https://phab.mercurial-scm.org/D2237
contrib/check-code.py file | annotate | diff | comparison | revisions 
--- a/contrib/check-code.py	Tue Feb 13 17:58:40 2018 -0500
+++ b/contrib/check-code.py	Tue Feb 13 18:00:59 2018 -0500
@@ -150,6 +150,7 @@
     (r'grep.* -[ABC]', "don't use grep's context flags"),
     (r'find.*-printf',
      "don't use 'find -printf', it doesn't exist on BSD find(1)"),
+    (r'\$RANDOM ', "don't use bash-only $RANDOM to generate random values"),
   ],
   # warnings
   [
Mercurial