largefiles: call super class method with proper kwargs to respect API
authorLong Vu <long@tlvu.ca>
Tue, 03 Dec 2013 13:28:04 -0500
changeset 20177 c5f0574034ef
parent 20176 4c96c50ef937
child 20178 74aea4be8e78
largefiles: call super class method with proper kwargs to respect API Since the localrepositoyry.push() method in mercurial/localrepo.py is defined this way: def push(self, remote, force=False, revs=None, newbranch=False): it is better for largefiles to call push() on the super class with proper kwargs to respect the API. This will avoid breaking other extensions overriding the push method this way: def push(self, remote, force=False, **kwargs):
hgext/largefiles/reposetup.py
--- a/hgext/largefiles/reposetup.py	Wed Nov 13 15:55:30 2013 +0900
+++ b/hgext/largefiles/reposetup.py	Tue Dec 03 13:28:04 2013 -0500
@@ -445,8 +445,8 @@
                              for f in files
                              if lfutil.isstandin(f) and f in ctx]))
                 lfcommands.uploadlfiles(ui, self, remote, toupload)
-            return super(lfilesrepo, self).push(remote, force, revs,
-                newbranch)
+            return super(lfilesrepo, self).push(remote, force=force, revs=revs,
+                newbranch=newbranch)
 
         def _subdirlfs(self, files, lfiles):
             '''