dagop: comment why revancestors() doesn't heapify input revs at once
authorYuya Nishihara <yuya@tcha.org>
Sun, 18 Jun 2017 17:16:02 +0900
changeset 32998 c7da57bbae96
parent 32997 b9e2269aeff8
child 32999 08e2793d9f65
dagop: comment why revancestors() doesn't heapify input revs at once I wondered why we're doing this complicated stuff without noticing the input revs may be iterated lazily in descending order. c1f666e27345 showed why.
mercurial/dagop.py
--- a/mercurial/dagop.py	Sat Jun 17 22:33:23 2017 +0900
+++ b/mercurial/dagop.py	Sun Jun 18 17:16:02 2017 +0900
@@ -26,6 +26,9 @@
     else:
         cut = None
     cl = repo.changelog
+
+    # load input revs lazily to heap so earlier revisions can be yielded
+    # without fully computing the input revs
     revs.sort(reverse=True)
     irevs = iter(revs)
     h = []