Mercurial > hg
changeset 26344:cd9cc7f30427
largefiles: remove a mutable default argument
Mutable default arguments are know to the state of California to cause bugs.
| author | Pierre-Yves David <pierre-yves.david@fb.com> |
|---|---|
| date | Thu, 24 Sep 2015 00:49:02 -0700 |
| parents | 019559aa2e80 |
| children | 2aa0dde846b4 |
| files | hgext/largefiles/overrides.py |
| diffstat | 1 files changed, 3 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/hgext/largefiles/overrides.py Thu Sep 24 00:48:24 2015 -0700 +++ b/hgext/largefiles/overrides.py Thu Sep 24 00:49:02 2015 -0700 @@ -1172,8 +1172,10 @@ finally: repo.lfstatus = False -def scmutiladdremove(orig, repo, matcher, prefix, opts={}, dry_run=None, +def scmutiladdremove(orig, repo, matcher, prefix, opts=None, dry_run=None, similarity=None): + if opts is None: + opts = {} if not lfutil.islfilesrepo(repo): return orig(repo, matcher, prefix, opts, dry_run, similarity) # Get the list of missing largefiles so we can remove them