Mercurial > hg
changeset 32044:cde72a195f32
dispatch: ignore further SIGPIPE while handling KeyboardInterrupt
I got the following error by running "hg log" and quitting the pager
immediately. Any output here may trigger another SIGPIPE, so only thing
we can do is to swallow the exception and exit with an error status.
Traceback (most recent call last):
File "./hg", line 45, in <module>
mercurial.dispatch.run()
File "mercurial/dispatch.py", line 83, in run
status = (dispatch(req) or 0) & 255
File "mercurial/dispatch.py", line 167, in dispatch
req.ui.warn(_("interrupted!\n"))
File "mercurial/ui.py", line 1224, in warn
self.write_err(*msg, **opts)
File "mercurial/ui.py", line 790, in write_err
self._write_err(*msgs, **opts)
File "mercurial/ui.py", line 798, in _write_err
self.ferr.write(a)
File "mercurial/ui.py", line 129, in _catchterm
raise error.SignalInterrupt
mercurial.error.SignalInterrupt
Perhaps this wasn't visible before de5c9d0e02ea because the original stderr
handle was restored very late.
author | Yuya Nishihara <yuya@tcha.org> |
---|---|
date | Mon, 17 Apr 2017 23:53:19 +0900 |
parents | b844d0d367e2 |
children | 3eceeede26e9 |
files | mercurial/dispatch.py |
diffstat | 1 files changed, 4 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/mercurial/dispatch.py Sat Apr 15 13:04:55 2017 +0900 +++ b/mercurial/dispatch.py Mon Apr 17 23:53:19 2017 +0900 @@ -165,6 +165,10 @@ except KeyboardInterrupt: try: req.ui.warn(_("interrupted!\n")) + except error.SignalInterrupt: + # maybe pager would quit without consuming all the output, and + # SIGPIPE was raised. we cannot print anything in this case. + pass except IOError as inst: if inst.errno != errno.EPIPE: raise