changeset 2903:ce967d96a1c1

Properly shell-quote arguments in extdiff
author Brendan Cully <brendan@kublai.com>
date Mon, 14 Aug 2006 11:10:21 -0700
parents 2fe4d99ae726
children 57b88b86a845
files hgext/extdiff.py
diffstat 1 files changed, 3 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/hgext/extdiff.py	Mon Aug 14 11:07:15 2006 -0700
+++ b/hgext/extdiff.py	Mon Aug 14 11:10:21 2006 -0700
@@ -92,8 +92,9 @@
             dir2 = snapshot_node(modified + added, node2)
         else:
             dir2 = snapshot_wdir(modified + added)
-        util.system('%s %s "%s" "%s"' %
-                    (diffcmd, ' '.join(opts['option']), dir1, dir2),
+        util.system('%s %s %s %s' %
+                    (util.shellquote(diffcmd), ' '.join(opts['option']),
+                     util.shellquote(dir1), util.shellquote(dir2)),
                     cwd=tmproot)
         return 1
     finally: