Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
debuginstall: strip double quotes from editorbin on Windows
authorMatt Harbison <matt_harbison@yahoo.com>
Tue, 20 Feb 2018 22:03:13 -0500
changeset 36335 d639f60c8eb3
parent 36334 4cd2d1cc2a31
child 36336 236596a67a54
debuginstall: strip double quotes from editorbin on Windows The unconditional posix style shlex.split() prior to 94a1ff16f362 handled this. This isn't mutually exclusive with stripping the quotes in util.findexe()- if the editor can't be found, this command prints out the string, inside single quotes.
mercurial/debugcommands.py file | annotate | diff | comparison | revisions 
--- a/mercurial/debugcommands.py	Tue Feb 20 21:37:30 2018 -0500
+++ b/mercurial/debugcommands.py	Tue Feb 20 22:03:13 2018 -0500
@@ -1241,6 +1241,8 @@
     editor = ui.geteditor()
     editor = util.expandpath(editor)
     editorbin = pycompat.shlexsplit(editor, posix=not pycompat.iswindows)[0]
+    if pycompat.iswindows and editorbin[0] == '"' and editorbin[-1] == '"':
+        editorbin = editorbin[1:-1]
     fm.write('editor', _("checking commit editor... (%s)\n"), editorbin)
     cmdpath = util.findexe(editorbin)
     fm.condwrite(not cmdpath and editor == 'vi', 'vinotfound',
Mercurial