Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
statprof: use context manager for file when writing flame graph
authorMartin von Zweigbergk <martinvonz@google.com>
Fri, 30 Aug 2019 16:44:31 -0700
changeset 42835 db6d7cbda80b
parent 42834 c085cb134b9e
child 42836 cd3b5be5515d
statprof: use context manager for file when writing flame graph Differential Revision: https://phab.mercurial-scm.org/D6780
mercurial/statprof.py file | annotate | diff | comparison | revisions 
--- a/mercurial/statprof.py	Fri Aug 30 16:43:43 2019 -0700
+++ b/mercurial/statprof.py	Fri Aug 30 16:44:31 2019 -0700
@@ -729,10 +729,6 @@
         fp.write(b'get it here: https://github.com/brendangregg/FlameGraph\n')
         return
 
-    fd, path = pycompat.mkstemp()
-
-    file = open(path, "w+")
-
     lines = {}
     for sample in data.samples:
         sites = [s.function for s in sample.stack]
@@ -743,10 +739,11 @@
         else:
             lines[line] = 1
 
-    for line, count in lines.iteritems():
-        file.write("%s %d\n" % (line, count))
+    fd, path = pycompat.mkstemp()
 
-    file.close()
+    with open(path, "w+") as file:
+        for line, count in lines.iteritems():
+            file.write("%s %d\n" % (line, count))
 
     if outputfile is None:
         outputfile = '~/flamegraph.svg'
Mercurial