changeset 48146:de0977ec2d25

dirstate: drop an incorrect comment We are actually checking that we are only in a case were the file might needs lookup before doing this. So the comment is not relevant. Differential Revision: https://phab.mercurial-scm.org/D11590
author Pierre-Yves David <pierre-yves.david@octobus.net>
date Fri, 01 Oct 2021 02:43:39 +0200
parents 180e8fa345cc
children 142e9f0a70b5
files mercurial/dirstate.py
diffstat 1 files changed, 1 insertions(+), 4 deletions(-) [+]
line wrap: on
line diff
--- a/mercurial/dirstate.py	Fri Oct 01 01:45:20 2021 +0200
+++ b/mercurial/dirstate.py	Fri Oct 01 02:43:39 2021 +0200
@@ -579,10 +579,7 @@
             not possibly_dirty and not p2_info and wc_tracked and p1_tracked
         )
 
-        # this mean we are doing call for file we do not really care about the
-        # data (eg: added or removed), however this should be a minor overhead
-        # compared to the overall update process calling this.
-        if need_parent_file_data or parentfiledata is None:
+        if need_parent_file_data and parentfiledata is None:
             parentfiledata = self._get_filedata(filename)
 
         self._map.reset_state(