zeroconf: constant-fold a `pycompat.ispy3`
authorManuel Jacob <me@manueljacob.de>
Tue, 31 May 2022 02:04:24 +0200
changeset 49293 e3143ab9dadb
parent 49292 33872fec41e7
child 49294 003c0732c055
zeroconf: constant-fold a `pycompat.ispy3` I’ve checked that both bytes and str gets passed as the `name` parameter, so the rest of the condition is still required. Because there aren’t really any tests for the extensions, I didn’t want to refactor it to pass a single type.
hgext/zeroconf/Zeroconf.py
--- a/hgext/zeroconf/Zeroconf.py	Tue May 31 01:23:19 2022 +0200
+++ b/hgext/zeroconf/Zeroconf.py	Tue May 31 02:04:24 2022 +0200
@@ -292,7 +292,7 @@
     """A DNS question entry"""
 
     def __init__(self, name, type, clazz):
-        if pycompat.ispy3 and isinstance(name, str):
+        if isinstance(name, str):
             name = name.encode('ascii')
         if not name.endswith(b".local."):
             raise NonLocalNameException(name)