Mercurial > hg
changeset 19081:e97ce4a5afc5 stable
check-code: expand sed rule to include more offenders
Expands the rule added in 5e4491c114b2 to include cases where the
address is a line number instead of a regular expression, and fixes an
instance of this pattern in test-unionrepo.t.
| author | Kevin Bullock <kbullock@ringworld.org> |
|---|---|
| date | Mon, 22 Apr 2013 16:50:08 -0500 |
| parents | 5e4491c114b2 |
| children | 63dda3c3bb11 |
| files | contrib/check-code.py tests/test-unionrepo.t |
| diffstat | 2 files changed, 3 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/contrib/check-code.py Mon Apr 22 16:33:28 2013 -0500 +++ b/contrib/check-code.py Mon Apr 22 16:50:08 2013 -0500 @@ -74,7 +74,7 @@ (r'/dev/u?random', "don't use entropy, use /dev/zero"), (r'do\s*true;\s*done', "don't use true as loop body, use sleep 0"), (r'^( *)\t', "don't use tabs to indent"), - (r'sed .*\'/[^/]*/i[^\\][^\n]', + (r'sed .*\'(\d+|/[^/]*/)i[^\\][^\n]', "put a backslash-escaped newline after sed 'i' command"), ], # warnings
--- a/tests/test-unionrepo.t Mon Apr 22 16:33:28 2013 -0500 +++ b/tests/test-unionrepo.t Mon Apr 22 16:50:08 2013 -0500 @@ -25,7 +25,8 @@ $ hg clone -q repo1 --rev 0 repo2 $ cd repo2 $ touch repo2-1 - $ sed '1irepo2-1 at top' f > f.tmp + $ sed '1i\ + > repo2-1 at top' f > f.tmp $ mv f.tmp f $ hg ci -Aqmrepo2-1 $ touch repo2-2