Mercurial > hg

changeset 51236:eb676c35a29b

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
rust-index: support `unionrepo`'s compressed length hack Explanations inline.
author Raphaël Gomès <rgomes@octobus.net>
date Tue, 31 Oct 2023 17:58:56 +0100
parents 456e0fe702e8
children 49b00a04028f
files rust/hg-core/src/revlog/index.rs
diffstat 1 files changed, 12 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/rust/hg-core/src/revlog/index.rs	Fri Oct 27 23:21:50 2023 +0200
+++ b/rust/hg-core/src/revlog/index.rs	Tue Oct 31 17:58:56 2023 +0100
@@ -479,7 +479,18 @@
             } else {
                 e.raw_offset()
             },
-            data_compressed_length: e.compressed_len().try_into().unwrap(),
+            data_compressed_length: e
+                .compressed_len()
+                .try_into()
+                .unwrap_or_else(|_| {
+                    // Python's `unionrepo` sets the compressed length to be
+                    // `-1` (or `u32::MAX` if transmuted to `u32`) because it
+                    // cannot know the correct compressed length of a given
+                    // revision. I'm not sure if this is true, but having this
+                    // edge case won't hurt other use cases, let's handle it.
+                    assert_eq!(e.compressed_len(), u32::MAX);
+                    NULL_REVISION.0
+                }),
             data_uncompressed_length: e.uncompressed_len(),
             data_delta_base: e.base_revision_or_base_of_delta_chain().0,
             link_rev: e.link_revision().0,