--- a/contrib/check-code.py Sun Oct 16 20:26:20 2011 -0500
+++ b/contrib/check-code.py Sun Oct 16 22:15:43 2011 -0500
@@ -69,6 +69,7 @@
(r'ls\s+[^|\n-]+\s+-', "options to 'ls' must come before filenames"),
(r'[^>\n]>\s*\$HGRCPATH', "don't overwrite $HGRCPATH, append to it"),
(r'stop\(\)', "don't use 'stop' as a shell function name"),
+ (r'(\[|\btest\b).*-e ', "don't use 'test -e', use 'test -f'"),
],
# warnings
[]
--- a/tests/test-subrepo-svn.t Sun Oct 16 20:26:20 2011 -0500
+++ b/tests/test-subrepo-svn.t Sun Oct 16 22:15:43 2011 -0500
@@ -581,5 +581,5 @@
A $TESTTMP/rebaserepo/recreated/somethingold
Checked out revision 10.
1 files updated, 0 files merged, 0 files removed, 0 files unresolved
- $ test -e recreated/somethingold
+ $ test -f recreated/somethingold