crecord: drop the extra confirmation screen
The commit confirmation is not very useful -- it gives no way to view what you
have selected, so you're blindly choosing whether to proceed or not, and it adds
a lot of unnecessary friction to committing. In addition, we now have a working
'review' choice for those who really want to review the final change.
Ryan McElroy initially submitted a config option to make this optional, but we
never saw a V2. However as the freeze is near and curses have never been
officially out of the door, I think it is worth skipping the config and trying
getting it right for this release.
--- a/mercurial/crecord.py Fri Apr 15 20:37:11 2016 +0900
+++ b/mercurial/crecord.py Thu Apr 14 01:27:18 2016 -0700
@@ -1600,8 +1600,7 @@
elif keypressed in ['a']:
self.toggleamend(self.opts, test)
elif keypressed in ["c"]:
- if self.confirmcommit():
- return True
+ return True
elif test and keypressed in ['X']:
return True
elif keypressed in ["r"]: