Mercurial > hg
changeset 45820:ee826f43cf4f
hgweb: don't call sys.exit() in httpservice.run()
If I'm reading the code correctly, `mercurial.server.createservice()`
can return an hgweb service or one of three types of command server
services. The caller then calls `mercurial.server.runservice()`,
passing it the returned service's run method. Only the hgweb service
was calling `sys.exit()`. It has been that way since 8d44649df03b
(refactor ssh server., 2006-06-04). That commit message doesn't
provide any explanation. Let's clean up and have the code follow the
usual return path into the `dispatch` module.
After this patch, there should be no remaining places left where we
call `sys.exit()` except for valid uses in the `dispatch` and `worker`
modules.
Differential Revision: https://phab.mercurial-scm.org/D9272
| author | Martin von Zweigbergk <martinvonz@google.com> |
|---|---|
| date | Tue, 03 Nov 2020 20:28:23 -0800 |
| parents | d6279c43fc60 |
| children | c2837640aeb0 |
| files | mercurial/hgweb/__init__.py |
| diffstat | 1 files changed, 0 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/mercurial/hgweb/__init__.py Tue Nov 03 20:20:49 2020 -0800 +++ b/mercurial/hgweb/__init__.py Tue Nov 03 20:28:23 2020 -0800 @@ -9,7 +9,6 @@ from __future__ import absolute_import import os -import sys from ..i18n import _ @@ -112,7 +111,6 @@ def run(self): self.httpd.serve_forever() - sys.exit(0) def createapp(baseui, repo, webconf):