Mercurial > hg
changeset 29115:ef316c653b7f
sslutil: stop checking for web.cacerts=! (BC)
The previous patch stopped setting web.cacerts=! to indicate
--insecure.
That left user configs as the only source that could introduce
web.cacerts=!.
The practical impact of this patch is we no longer honor
web.cacerts=! in configs. Instead, we always treat web.cacerts
as a path. The patch is therefore technically BC. However,
since I don't believe web.cacerts=! is documented, it should be
safe to remove. a939f08fae9c (which introduced --insecure) has
no indication that web.cacerts=! is anything but an implementation
detail, reinforcing my belief it can be removed without major
debate.
| author | Gregory Szorc <gregory.szorc@gmail.com> |
|---|---|
| date | Thu, 05 May 2016 00:46:31 -0700 |
| parents | f1081aea19b1 |
| children | 0c9b05dae010 |
| files | mercurial/sslutil.py |
| diffstat | 1 files changed, 0 insertions(+), 3 deletions(-) [+] |
line wrap: on
line diff
--- a/mercurial/sslutil.py Thu May 05 00:40:01 2016 -0700 +++ b/mercurial/sslutil.py Thu May 05 00:46:31 2016 -0700 @@ -254,9 +254,6 @@ return kws cacerts = ui.config('web', 'cacerts') - # TODO remove check when we stop setting this config. - if cacerts == '!': - return kws # If a value is set in the config, validate against a path and load # and require those certs.