changeset 22213:f1debbcd71cd

revert: add an XXX about rename tracking We check for rename information in the dirstate. This is probably not enough to preserve this behavior when using an explicit target rev. I just spotted this while working on this code, but this is outside the scope of my series so I'm just adding a comment to highlight this suspicious situation.
author Pierre-Yves David <pierre-yves.david@fb.com>
date Tue, 24 Jun 2014 16:59:40 +0100
parents f18aca03ddd9
children 3f93eff1de57
files mercurial/cmdutil.py
diffstat 1 files changed, 1 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/mercurial/cmdutil.py	Tue Jun 24 17:39:43 2014 +0100
+++ b/mercurial/cmdutil.py	Tue Jun 24 16:59:40 2014 +0100
@@ -2450,6 +2450,7 @@
         cwd = repo.getcwd()
         for f in dsadded:
             src = repo.dirstate.copied(f)
+            # XXX should we check for rename down to target node?
             if src and src not in names and repo.dirstate[src] == 'r':
                 dsremoved.add(src)
                 names[src] = (repo.pathto(src, cwd), True)