changeset 42484:f305f1d7d559

rust-filepatterns: add comment about Windows path handling As I replied to the Phabricator message, this is wrong. And I even suspect it wouldn't compile because of multiple type mismatches. I think, in Rust where type system is rock solid, we can live with UTF-8 strings except for the bottom storage layer and the top UI/command layer. We'll still have to get around undecodable characters not to be lost, but I think it's okay to drop such filenames from match result if they don't match in UTF-8 world, not in Latin-1 world.
author Yuya Nishihara <yuya@tcha.org>
date Sat, 15 Jun 2019 10:58:53 +0900
parents a4a468b00d44
children 4c39c99d9492
files rust/hg-core/src/utils/files.rs
diffstat 1 files changed, 2 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/rust/hg-core/src/utils/files.rs	Sat Jun 15 10:35:53 2019 +0900
+++ b/rust/hg-core/src/utils/files.rs	Sat Jun 15 10:58:53 2019 +0900
@@ -9,6 +9,8 @@
     }
     #[cfg(windows)]
     {
+        // TODO: convert from Windows MBCS (ANSI encoding) to WTF8.
+        // Perhaps, the return type would have to be Result<PathBuf>.
         use std::os::windows::ffi::OsStrExt;
         os_str = std::ffi::OsString::from_wide(bytes);
     }