Mercurial Mercurial > hg / changeset
summary | shortlog | changelog | graph | tags | bookmarks | branches | files | changeset | raw | zip | gz | bz2 | help
Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
util: avoid a leaked file descriptor in `util.makelock()` exceptional case
authorMatt Harbison <matt_harbison@yahoo.com>
Fri, 20 Sep 2024 00:20:24 -0400
changeset 51888 f833ad92ee44
parent 51887 1d95a87813ad
child 51889 cbd01bf33802
util: avoid a leaked file descriptor in `util.makelock()` exceptional case
mercurial/util.py file | annotate | diff | comparison | revisions 
--- a/mercurial/util.py	Fri Sep 20 00:04:09 2024 -0400
+++ b/mercurial/util.py	Fri Sep 20 00:20:24 2024 -0400
@@ -2201,8 +2201,10 @@
 
     flags = os.O_CREAT | os.O_WRONLY | os.O_EXCL | getattr(os, 'O_BINARY', 0)
     ld = os.open(pathname, flags)
-    os.write(ld, info)
-    os.close(ld)
+    try:
+        os.write(ld, info)
+    finally:
+        os.close(ld)
 
 
 def readlock(pathname: bytes) -> bytes:
Mercurial