Mercurial > hg
changeset 33637:f9134e96ed0f stable
clone: add tests for unsafe ssh url (SEC)
| author | Sean Farley <sean@farley.io> |
|---|---|
| date | Fri, 28 Jul 2017 16:36:36 -0700 |
| parents | f93975a5ebe8 |
| children | 92b583e3e522 |
| files | tests/test-clone.t |
| diffstat | 1 files changed, 22 insertions(+), 0 deletions(-) [+] |
line wrap: on
line diff
--- a/tests/test-clone.t Tue Aug 01 14:40:19 2017 -0700 +++ b/tests/test-clone.t Fri Jul 28 16:36:36 2017 -0700 @@ -1092,3 +1092,25 @@ adding remote bookmark bookA updating working directory 1 files updated, 0 files merged, 0 files removed, 0 files unresolved + +SEC: check for unsafe ssh url + + $ hg clone 'ssh://-oProxyCommand=touch${IFS}owned/path' + abort: potentially unsafe url: 'ssh://-oProxyCommand=touch${IFS}owned/path' + [255] + $ hg clone 'ssh://%2DoProxyCommand=touch${IFS}owned/path' + abort: potentially unsafe url: 'ssh://-oProxyCommand=touch${IFS}owned/path' + [255] + $ hg clone 'ssh://fakehost|shellcommand/path' + abort: potentially unsafe url: 'ssh://fakehost|shellcommand/path' + [255] + $ hg clone 'ssh://fakehost%7Cshellcommand/path' + abort: potentially unsafe url: 'ssh://fakehost|shellcommand/path' + [255] + + $ hg clone 'ssh://-oProxyCommand=touch owned%20foo@example.com/nonexistent/path' + abort: potentially unsafe url: 'ssh://-oProxyCommand=touch owned foo@example.com/nonexistent/path' + [255] +We should not have created a file named owned - if it exists, the +attack succeeded. + $ if test -f owned; then echo 'you got owned'; fi