largefiles: verify status should be written as status, not as write
Make 'hg verify --large -q' quiet when no errors.
--- a/hgext/largefiles/basestore.py Mon Feb 04 02:46:53 2013 +0100
+++ b/hgext/largefiles/basestore.py Mon Feb 04 02:46:53 2013 +0100
@@ -96,10 +96,10 @@
'''Verify the existence (and, optionally, contents) of every big
file revision referenced by every changeset in revs.
Return 0 if all is well, non-zero on any errors.'''
- write = self.ui.write
failed = False
- write(_('searching %d changesets for largefiles\n') % len(revs))
+ self.ui.status(_('searching %d changesets for largefiles\n') %
+ len(revs))
verified = set() # set of (filename, filenode) tuples
for rev in revs:
@@ -113,12 +113,13 @@
numrevs = len(verified)
numlfiles = len(set([fname for (fname, fnode) in verified]))
if contents:
- write(_('verified contents of %d revisions of %d largefiles\n')
- % (numrevs, numlfiles))
+ self.ui.status(
+ _('verified contents of %d revisions of %d largefiles\n')
+ % (numrevs, numlfiles))
else:
- write(_('verified existence of %d revisions of %d largefiles\n')
- % (numrevs, numlfiles))
-
+ self.ui.status(
+ _('verified existence of %d revisions of %d largefiles\n')
+ % (numrevs, numlfiles))
return int(failed)
def _getfile(self, tmpfile, filename, hash):
--- a/tests/test-largefiles.t Mon Feb 04 02:46:53 2013 +0100
+++ b/tests/test-largefiles.t Mon Feb 04 02:46:53 2013 +0100
@@ -1209,9 +1209,7 @@
- introduce corruption and make sure that it is caught when checking content:
$ echo '5 cents' > $TESTTMP/d/.hg/largefiles/e166e74c7303192238d60af5a9c4ce9bef0b7928
$ hg verify -q --large --lfc
- searching 1 changesets for largefiles
changeset 9:598410d3eb9a: sub/large4 references corrupted $TESTTMP/d/.hg/largefiles/e166e74c7303192238d60af5a9c4ce9bef0b7928
- verified contents of 3 revisions of 3 largefiles
[1]
- cleanup
@@ -1220,7 +1218,6 @@
- verifying all revisions will fail because we didn't clone all largefiles to d:
$ echo 'T-shirt' > $TESTTMP/d/.hg/largefiles/eb7338044dc27f9bc59b8dd5a246b065ead7a9c4
$ hg verify -q --large --lfa --lfc
- searching 10 changesets for largefiles
changeset 0:30d30fe6a5be: large1 references missing $TESTTMP/d/.hg/largefiles/4669e532d5b2c093a78eca010077e708a071bb64
changeset 0:30d30fe6a5be: sub/large2 references missing $TESTTMP/d/.hg/largefiles/1deebade43c8c498a3c8daddac0244dc55d1331d
changeset 1:ce8896473775: large1 references missing $TESTTMP/d/.hg/largefiles/5f78770c0e77ba4287ad6ef3071c9bf9c379742f
@@ -1228,7 +1225,6 @@
changeset 3:9e8fbc4bce62: large1 references corrupted $TESTTMP/d/.hg/largefiles/eb7338044dc27f9bc59b8dd5a246b065ead7a9c4
changeset 4:74c02385b94c: large3 references corrupted $TESTTMP/d/.hg/largefiles/eb7338044dc27f9bc59b8dd5a246b065ead7a9c4
changeset 4:74c02385b94c: sub/large4 references corrupted $TESTTMP/d/.hg/largefiles/eb7338044dc27f9bc59b8dd5a246b065ead7a9c4
- verified contents of 15 revisions of 6 largefiles
[1]
- cleanup
@@ -1637,8 +1633,6 @@
[1]
$ mv 02a439e5c31c526465ab1a0ca1f431f76b827b90 empty/.hg/largefiles/
$ hg -R http-clone -q verify --large --lfa
- searching 1 changesets for largefiles
- verified existence of 1 revisions of 1 largefiles
largefiles pulled on update - a largefile missing on the server:
$ mv empty/.hg/largefiles/02a439e5c31c526465ab1a0ca1f431f76b827b90 .