Mercurial > hg

changeset 16344:fb765286f2f9 stable

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
tests: avoid zombie lockup with test-hup The 'while kill -0' recipe can cause a livelock if the process we're waiting to die is a normal child process. If it becomes a zombie that the shell doesn't reap (shell bug?), it will continue to be able to accept signals. So instead, we just wait(1).
author Matt Mackall <mpm@selenic.com>
date Mon, 02 Apr 2012 16:46:58 -0500
parents 7e24d34837a9
children 825565136235
files tests/test-hup.t
diffstat 1 files changed, 1 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/tests/test-hup.t	Mon Apr 02 16:04:07 2012 -0500
+++ b/tests/test-hup.t	Mon Apr 02 16:46:58 2012 -0500
@@ -15,7 +15,7 @@
   > kill -HUP $P
   > ) > p
 
-  $ while kill -0 $P 2>/dev/null; do true; done
+  $ wait
   $ cat out
   0
   0