Mercurial > hg
changeset 40037:fcad7fdc6474
identify: show remote bookmarks in `hg id url -Tjson -B`
I didn't display bookmarks when `default and not ui.quiet`: it seems
strange for templates to depend on --id or -q, and it would take more
code for `hg id url -T {node}` to not request remote bookmarks.
An alternative I thought of was providing lazy data to the formatter,
`fm.data(bookmarks=lambda: fm.formatlist(getbms(), name='bookmark'))`.
The plainformatter would naturally not compute it, the
templateformatter would compute only what it needs, and the other ones
would compute everything, but that's not supported (or I don't see
how), so I abandoned this idea.
Differential Revision: https://phab.mercurial-scm.org/D4872
| author | Valentin Gatien-Baron <vgatien-baron@janestreet.com> |
|---|---|
| date | Wed, 03 Oct 2018 18:07:49 -0400 |
| parents | acf5dbe39478 |
| children | 906c95073ff7 |
| files | mercurial/commands.py |
| diffstat | 1 files changed, 1 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/mercurial/commands.py Wed Oct 03 16:03:16 2018 -0400 +++ b/mercurial/commands.py Wed Oct 03 18:07:49 2018 -0400 @@ -3111,7 +3111,7 @@ output.append(bm) else: fm.data(node=hex(remoterev)) - if 'bookmarks' in fm.datahint(): + if bookmarks or 'bookmarks' in fm.datahint(): fm.data(bookmarks=fm.formatlist(getbms(), name='bookmark')) else: if rev: