comparison hglib/client.py @ 176:3f854e3bcdd1 2.2

client: raise KeyError from __getitem__ (BC)

object.__getitem__ is supposed to raise either IndexError or KeyError
(depending on whether the thing is a sequence or a mapping). Before,
we would raise ValueError because that's what the context constructor
raises.

I choose to raise KeyError because IndexError felt a bit too limiting.
This does sacrifice some magic with for loops handling IndexError.
However, iteration of this object should be handled by a custom
__iter__, so I don't think this is a problem.

175:c16e2087660f

            self._version = tuple(v)

        return self._version

    def __getitem__(self, changeid):
        return context.changectx(self, changeid)

    def __contains__(self, changeid):
        """
        check if changeid, which can be either a local revision number or a
        changeset id, matches a changeset in the client.

176:3f854e3bcdd1

            self._version = tuple(v)

        return self._version

    def __getitem__(self, changeid):
        try:
            return context.changectx(self, changeid)
        except ValueError as e:
            raise KeyError(*e.args)

    def __contains__(self, changeid):
        """
        check if changeid, which can be either a local revision number or a
        changeset id, matches a changeset in the client.