comparison hglib/client.py @ 190:f38bc0569671

client: don't swallow ResponseError inside open()

_readhello() can generate meaningful ResponseError exceptions. However,
open()'s exception handler swallows these, converting them into generic
ServerErrors. Allow the original ResponseErrors to pass through.

189:8054e925d9c7

            raise ValueError('server already open')

        self.server = util.popen(self._args, self._env)
        try:
            self._readhello()
        except error.ServerError:
            ret, serr = self._close()
            raise error.ServerError('server exited with status %d: %s'
                                    % (ret, serr.strip()))
        return self

190:f38bc0569671

            raise ValueError('server already open')

        self.server = util.popen(self._args, self._env)
        try:
            self._readhello()
        except error.ResponseError:
            self.close()
            raise
        except error.ServerError:
            ret, serr = self._close()
            raise error.ServerError('server exited with status %d: %s'
                                    % (ret, serr.strip()))
        return self