view .hgsigs @ 176:3f854e3bcdd1 2.2

client: raise KeyError from __getitem__ (BC) object.__getitem__ is supposed to raise either IndexError or KeyError (depending on whether the thing is a sequence or a mapping). Before, we would raise ValueError because that's what the context constructor raises. I choose to raise KeyError because IndexError felt a bit too limiting. This does sacrifice some magic with for loops handling IndexError. However, iteration of this object should be handled by a custom __iter__, so I don't think this is a problem.
author Gregory Szorc <gregory.szorc@gmail.com>
date Wed, 06 Jul 2016 14:14:22 -0700
parents bfd1c264f6cb
children 1085c904d8c0
line wrap: on
line source

c41442cb355d55ca152d5f13a95a6bf2ebc5b870 0 iD8DBQBOvGIzywK+sNU5EO8RAtNMAJ92vXmPkE35jrLlclws5h0TAFUHVQCfVjGoqNgnh+ZE7eI25Q/m555XvEU=