Mercurial > evolve
changeset 4101:88000f1d2406 stable
firstmergecache: ignore permission and OS errors when writing
This cache is related to the obshashrange one and we update it lazily by
default.
This can be an issue when pulling locally from a read only repository that was
not configured for a more aggressive cache warming. The raised permission error
was uncaught and could crash the whole process. Errors during cache update
should not block Mercurial operations.
| author | Pierre-Yves David <pierre-yves.david@octobus.net> |
|---|---|
| date | Thu, 13 Sep 2018 17:08:18 +0200 |
| parents | f21187478dcc |
| children | 3895f6fcd35c |
| files | hgext3rd/evolve/firstmergecache.py |
| diffstat | 1 files changed, 9 insertions(+), 6 deletions(-) [+] |
line wrap: on
line diff
--- a/hgext3rd/evolve/firstmergecache.py Thu Sep 13 18:56:04 2018 +0200 +++ b/hgext3rd/evolve/firstmergecache.py Thu Sep 13 17:08:18 2018 +0200 @@ -135,9 +135,12 @@ if self._cachekey is None or self._cachekey == self._ondiskkey: return - cachevfs = compat.getcachevfs(repo) - cachefile = cachevfs(self._filepath, 'w', atomictemp=True) - headerdata = self._serializecachekey() - cachefile.write(headerdata) - cachefile.write(self._data.tostring()) - cachefile.close() + try: + cachevfs = compat.getcachevfs(repo) + cachefile = cachevfs(self._filepath, 'w', atomictemp=True) + headerdata = self._serializecachekey() + cachefile.write(headerdata) + cachefile.write(self._data.tostring()) + cachefile.close() + except (IOError, OSError) as exc: + repo.ui.debug('firstmergecache: could not write update %s\n' % exc)