mq: prefer a loop to a double-for list comprehension
The [x for y in l for x in y] syntax is nigh-incomprehensible, and this
is a particularly easy case to expand into a loop since there's no 'if'
condition in the list comprehension.
--- a/hgext/mq.py Sat Nov 23 18:34:32 2013 +0100
+++ b/hgext/mq.py Sun Nov 24 17:29:10 2013 -0600
@@ -1204,7 +1204,9 @@
diffopts = self.diffopts()
wlock = repo.wlock()
try:
- heads = [h for hs in repo.branchmap().itervalues() for h in hs]
+ heads = []
+ for hs in repo.branchmap().itervalues():
+ heads.extend(hs)
if not heads:
heads = [nullid]
if repo.dirstate.p1() not in heads and not exact: