safehasattr: pass attribute name as string instead of bytes
authorPierre-Yves David <pierre-yves.david@octobus.net>
Thu, 02 Feb 2023 17:21:45 +0100
changeset 50593 87b004378fc4
parent 50592 a5bba73a1352
child 50594 8020be6a9d28
safehasattr: pass attribute name as string instead of bytes This is a step toward replacing `util.safehasattr` usage with plain `hasattr`. The builtin function behave poorly in Python2 but this was fixed in Python3. These change are done one by one as they tend to have a small odd to trigger puzzling breackage.
mercurial/crecord.py
--- a/mercurial/crecord.py	Thu Feb 02 17:21:36 2023 +0100
+++ b/mercurial/crecord.py	Thu Feb 02 17:21:45 2023 +0100
@@ -1944,7 +1944,7 @@
         """
 
         origsigwinch = sentinel = object()
-        if util.safehasattr(signal, b'SIGWINCH'):
+        if util.safehasattr(signal, 'SIGWINCH'):
             origsigwinch = signal.signal(signal.SIGWINCH, self.sigwinchhandler)
         try:
             return self._main(stdscr)