Mercurial > hg-stable
changeset 22309:a65697c3f20e
obsolete: avoid slow, generic date parsing
Simple profiling of `hg log -r .` revealed ~18,000 calls to
mercurial.i18n.gettext() on the author's repository. The
culprit was 3 _() calls in util.parsedate() multiplied by
~6000 obsmarkers originating from the parsing of obsmarkers.
Changing the obsmarker code to parse the stored format of
dates instead of going through a generic path eliminates these
gettext() lookups and makes `hg log -r .` execute ~10% faster
on the author's repo. The performance gain is proportional to
the number of obsmarkers.
The author attempted to patch util.parsedate() to avoid the
gettext() lookups. However, that code is whacky and the author
is jet lagged, so the approach was not attempted.
| author | Gregory Szorc <gregory.szorc@gmail.com> |
|---|---|
| date | Fri, 29 Aug 2014 18:00:44 +0200 |
| parents | 246b6a9c8d8f |
| children | aabf367306d5 |
| files | mercurial/obsolete.py |
| diffstat | 1 files changed, 3 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/mercurial/obsolete.py Fri Aug 29 12:06:31 2014 +0200 +++ b/mercurial/obsolete.py Fri Aug 29 18:00:44 2014 +0200 @@ -170,8 +170,9 @@ off += mdsize meta = decodemeta(metadata) try: - date = util.parsedate(decodemeta(metadata).pop('date', '0 0')) - except util.Abort: + when, offset = decodemeta(metadata).pop('date', '0 0').split(' ') + date = float(when), int(offset) + except ValueError: date = (0., 0) parents = None if 'p2' in meta: