histedit: remove superfluous echo() and endwin() calls (issue6859)
ncurses patchlevel 20231111 started returning an error from endwin() if
called twice without a intervening screen update.
Per Sven Joachim in
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1058041#17: "AFAICS,
invoking curses.echo() and curses.endwin() is superfluous
because curses.wrapper already does that for you, and calling
curses.endwin() twice throws an error with the newer ncurses. Removing
those two lines should fix the problem."
--- a/hgext/histedit.py Thu Dec 07 14:22:55 2023 +0100
+++ b/hgext/histedit.py Tue Dec 12 11:47:48 2023 +0100
@@ -1760,8 +1760,6 @@
rules.append(histeditrule(ui, repo[r], i))
with util.with_lc_ctype():
rc = curses.wrapper(functools.partial(_chisteditmain, repo, rules))
- curses.echo()
- curses.endwin()
if rc is False:
ui.write(_(b"histedit aborted\n"))
return 0