py3: make sure we open the files in bytes mode
authorPulkit Goyal <7895pulkit@gmail.com>
Sun, 18 Feb 2018 18:22:40 +0530
changeset 36336 ed95758addf3
parent 36335 ba1807d9a846
child 36337 6d6bc544467a
py3: make sure we open the files in bytes mode Differential Revision: https://phab.mercurial-scm.org/D2333
mercurial/posix.py
--- a/mercurial/posix.py	Sun Feb 18 00:59:03 2018 -0500
+++ b/mercurial/posix.py	Sun Feb 18 18:22:40 2018 +0530
@@ -113,7 +113,7 @@
     if l:
         if not stat.S_ISLNK(s):
             # switch file to link
-            fp = open(f)
+            fp = open(f, 'rb')
             data = fp.read()
             fp.close()
             unlink(f)
@@ -121,7 +121,7 @@
                 os.symlink(data, f)
             except OSError:
                 # failed to make a link, rewrite file
-                fp = open(f, "w")
+                fp = open(f, "wb")
                 fp.write(data)
                 fp.close()
         # no chmod needed at this point
@@ -130,7 +130,7 @@
         # switch link to file
         data = os.readlink(f)
         unlink(f)
-        fp = open(f, "w")
+        fp = open(f, "wb")
         fp.write(data)
         fp.close()
         s = 0o666 & ~umask # avoid restatting for chmod