Mercurial > hg-stable
changeset 19380:ee07f9d142c9
check-code: do not warn on printf \\x or \\[1-9]
When there is a double backslash the following char does not have any special
meaning. So do not warn on this.
Remove the now obsolete no-check-code statement. (It was used wrongly anyway, it
skipped checking the entire file.)
| author | Simon Heimberg <simohe@besonet.ch> |
|---|---|
| date | Mon, 01 Jul 2013 06:50:58 +0200 |
| parents | 83d0df2ddf3f |
| children | e033a7d444ac |
| files | contrib/check-code.py tests/test-subrepo-paths.t |
| diffstat | 2 files changed, 3 insertions(+), 3 deletions(-) [+] |
line wrap: on
line diff
--- a/contrib/check-code.py Tue Nov 06 00:22:56 2012 +0100 +++ b/contrib/check-code.py Mon Jul 01 06:50:58 2013 +0200 @@ -68,8 +68,8 @@ (r'head -c', "don't use 'head -c', use 'dd'"), (r'sha1sum', "don't use sha1sum, use $TESTDIR/md5sum.py"), (r'ls.*-\w*R', "don't use 'ls -R', use 'find'"), - (r'printf.*\\([1-9]|0\d)', "don't use 'printf \NNN', use Python"), - (r'printf.*\\x', "don't use printf \\x, use Python"), + (r'printf.*[^\\]\\([1-9]|0\d)', "don't use 'printf \NNN', use Python"), + (r'printf.*[^\\]\\x', "don't use printf \\x, use Python"), (r'\$\(.*\)', "don't use $(expr), use `expr`"), (r'rm -rf \*', "don't use naked rm -rf, target a directory"), (r'(^|\|\s*)grep (-\w\s+)*[^|]*[(|]\w',
--- a/tests/test-subrepo-paths.t Tue Nov 06 00:22:56 2012 +0100 +++ b/tests/test-subrepo-paths.t Mon Jul 01 06:50:58 2013 +0200 @@ -17,7 +17,7 @@ hg debugsub with remapping $ echo '[subpaths]' >> .hg/hgrc - $ printf 'http://example.net/lib(.*) = C:\\libs\\\\1-lib\\\n' >> .hg/hgrc # no-check-code + $ printf 'http://example.net/lib(.*) = C:\\libs\\\\1-lib\\\n' >> .hg/hgrc $ hg debugsub path sub