Pierre-Yves David <pierre-yves.david@octobus.net> [Thu, 02 Feb 2023 17:20:54 +0100] rev 50557
safehasattr: pass attribute name as string instead of bytes
This is a step toward replacing `util.safehasattr` usage with plain `hasattr`.
The builtin function behave poorly in Python2 but this was fixed in Python3.
These change are done one by one as they tend to have a small odd to trigger
puzzling breackage.
Pierre-Yves David <pierre-yves.david@octobus.net> [Thu, 02 Feb 2023 17:20:46 +0100] rev 50556
safehasattr: pass attribute name as string instead of bytes
This is a step toward replacing `util.safehasattr` usage with plain `hasattr`.
The builtin function behave poorly in Python2 but this was fixed in Python3.
These change are done one by one as they tend to have a small odd to trigger
puzzling breackage.
Pierre-Yves David <pierre-yves.david@octobus.net> [Thu, 02 Feb 2023 17:19:55 +0100] rev 50555
safehasattr: pass attribute name as string instead of bytes
This is a step toward replacing `util.safehasattr` usage with plain `hasattr`.
The builtin function behave poorly in Python2 but this was fixed in Python3.
These change are done one by one as they tend to have a small odd to trigger
puzzling breackage.
Pierre-Yves David <pierre-yves.david@octobus.net> [Thu, 02 Feb 2023 17:19:46 +0100] rev 50554
safehasattr: pass attribute name as string instead of bytes
This is a step toward replacing `util.safehasattr` usage with plain `hasattr`.
The builtin function behave poorly in Python2 but this was fixed in Python3.
These change are done one by one as they tend to have a small odd to trigger
puzzling breackage.
Pierre-Yves David <pierre-yves.david@octobus.net> [Thu, 02 Feb 2023 17:19:35 +0100] rev 50553
safehasattr: pass attribute name as string instead of bytes
This is a step toward replacing `util.safehasattr` usage with plain `hasattr`.
The builtin function behave poorly in Python2 but this was fixed in Python3.
These change are done one by one as they tend to have a small odd to trigger
puzzling breackage.
Pierre-Yves David <pierre-yves.david@octobus.net> [Thu, 02 Feb 2023 17:19:26 +0100] rev 50552
safehasattr: pass attribute name as string instead of bytes
This is a step toward replacing `util.safehasattr` usage with plain `hasattr`.
The builtin function behave poorly in Python2 but this was fixed in Python3.
These change are done one by one as they tend to have a small odd to trigger
puzzling breackage.
Pierre-Yves David <pierre-yves.david@octobus.net> [Thu, 02 Feb 2023 17:18:37 +0100] rev 50551
safehasattr: pass attribute name as string instead of bytes
This is a step toward replacing `util.safehasattr` usage with plain `hasattr`.
The builtin function behave poorly in Python2 but this was fixed in Python3.
These change are done one by one as they tend to have a small odd to trigger
puzzling breackage.
Pierre-Yves David <pierre-yves.david@octobus.net> [Thu, 02 Feb 2023 17:18:24 +0100] rev 50550
safehasattr: pass attribute name as string instead of bytes
This is a step toward replacing `util.safehasattr` usage with plain `hasattr`.
The builtin function behave poorly in Python2 but this was fixed in Python3.
These change are done one by one as they tend to have a small odd to trigger
puzzling breackage.
Anton Shestakov <av6@dwimlabs.net> [Wed, 31 May 2023 12:02:56 -0300] rev 50549
debug: `isinstance(a, x) or isinstance(a, y)` is `isinstance(a, (x, y))`
Anton Shestakov <av6@dwimlabs.net> [Wed, 31 May 2023 12:01:25 -0300] rev 50548
debug: update usage strings of debugignore and debugnodemap
Multiple files can be specified for debugignore.
debugnodemap does not take a revision argument.
Anton Shestakov <av6@dwimlabs.net> [Wed, 31 May 2023 12:00:21 -0300] rev 50547
debug: slightly improve wording on the InputErrors from the previous patch
Anton Shestakov <av6@dwimlabs.net> [Wed, 31 May 2023 11:30:33 -0300] rev 50546
debug: use InputError instead of CommandError for validating arguments
Pierre-Yves David <pierre-yves.david@octobus.net> [Fri, 26 May 2023 17:41:25 +0200] rev 50545
clonebundle: add a `filter_bundle_url` function
This function does nothing by default, but give extension the opportunity to
alter the URL, typically, this could be used to inject authentication token when
serving clone bundle for private repositories.
Pierre-Yves David <pierre-yves.david@octobus.net> [Fri, 26 May 2023 16:55:52 +0200] rev 50544
clonebundles: move the manifest reading in a dedicated function
We are about to make the logic more advanced to help hosting solution, so we
need to centralize it first.
Joerg Sonnenberger <joerg@bec.de> [Wed, 31 May 2023 22:36:50 +0200] rev 50543
doc: format argument for date uses strftime format string (
issue6818)
Mathias De Mare <mathias.de_mare@nokia.com> [Thu, 20 Apr 2023 11:23:45 +0200] rev 50542
clonebundles: filter out invalid schemes instead of failing on them
Previously, an invalid clonebundle scheme would result in a failed
clone. By specifying a list of schemes we support,
we can make sure adding a new scheme (like the one for inline clonebundles)
does not result in clones failing for older clients.
Mathias De Mare <mathias.de_mare@nokia.com> [Thu, 20 Apr 2023 10:48:12 +0200] rev 50541
clonebundles: demonstrate bad behaviour when unknown scheme is present
Arseniy Alekseyev <aalekseyev@janestreet.com> [Mon, 29 May 2023 17:04:14 +0100] rev 50540
rhg: support `rhg files` with `ui.relative-paths=false`
Arseniy Alekseyev <aalekseyev@janestreet.com> [Mon, 29 May 2023 16:53:18 +0100] rev 50539
rhg: make `rhg files` work if `ui.relative-files=true` is specified
Arseniy Alekseyev <aalekseyev@janestreet.com> [Mon, 29 May 2023 16:47:39 +0100] rev 50538
rhg: test `rhg files --config ui.relative-paths ...`
Add some tests. All of these are falling back for now,
will be fixed in follow-up commits.
Arseniy Alekseyev <aalekseyev@janestreet.com> [Thu, 01 Jun 2023 12:05:32 +0100] rev 50537
cleanup: simplify code
Arseniy Alekseyev <aalekseyev@janestreet.com> [Wed, 31 May 2023 19:00:11 +0100] rev 50536
dirstate: better error messages when dirstate is corrupted
The current error message "Overflow in dirstate" sounds confusing
because it suggests either a certain size limit that's being exceeded,
or integer arithmetic overflowing. The reality is just a file being shorter
than expected.
Arseniy Alekseyev <aalekseyev@janestreet.com> [Wed, 31 May 2023 18:18:52 +0100] rev 50535
rust: remove an unused error variant DirstateMapError::EmptyPath
Jason R. Coombs <jaraco@jaraco.com> [Thu, 20 Apr 2023 16:07:47 -0400] rev 50534
hg: move unreachable code to where it could be reached
Arseniy Alekseyev <aalekseyev@janestreet.com> [Tue, 23 May 2023 01:39:47 +0200] rev 50533
stream-clone: support streamv3 on the cli [hg bundle]
We add support and test for this. The support is still experimental, so the
various name and identifier will eventually need to be renamed when stream-v3
gets out of experimental.
Pierre-Yves David <pierre-yves.david@octobus.net> [Tue, 23 May 2023 01:28:56 +0200] rev 50532
stream-clone: add the `-exp` prefix to the bundle part
We forget to do so in
58adcabc295f, however this is important to prevent
"current" client to send incompatible version to future client.
Joerg Sonnenberger <joerg@bec.de> [Mon, 21 Feb 2022 14:44:22 +0100] rev 50531
zstd: hack include order to ensure that our zstd.h is found
If the regular Python CFLAGS include directories that already have the
zstd headers available, a different and possible incompatible version
can be picked up otherwise. Sadly, it seems like Python has no easy way
to prefix flags before the rest.
Martin von Zweigbergk <martinvonz@google.com> [Thu, 18 May 2023 17:07:43 -0700] rev 50530
exchange: allow passing no includes/excludes to `pull()`
I would expect that `exchange.pull(includepats=[])` results in an empty list of
include patterns to be passed to the remote, but it doesn't currently because we
check for any truthy value instead of checking specifically for `not None`.
pacien <pacien.trangirard@pacien.net> [Tue, 16 May 2023 12:31:07 +0200] rev 50529
stabletailgraph: add test cases challenging the open merge stack
This adds three more complex test cases with situations requiring tricky
state update in the stack-based iteration (arriving soon).
pacien <pacien.trangirard@pacien.net> [Fri, 21 Apr 2023 14:33:33 +0200] rev 50528
stabletailgraph: naive version of leap computation
This adds a naive reference implementation of the computation of leap and
specific leap sets (described in the code documentation).
The existing tests are enriched accordingly.
pacien <pacien.trangirard@pacien.net> [Fri, 21 Apr 2023 16:19:32 +0200] rev 50527
stabletailgraph: extract _parents util func
pacien <pacien.trangirard@pacien.net> [Mon, 22 May 2023 19:04:05 +0200] rev 50526
stabletailgraph: clarify excl part size computation
pacien <pacien.trangirard@pacien.net> [Fri, 21 Apr 2023 14:32:58 +0200] rev 50525
stabletailgraph: clarify naiveness of current implementation
Both the naive and the actual versions of the algorithms are going to co-exist
for the tests. This makes is clearer that this one is naive.
Pierre-Yves David <pierre-yves.david@octobus.net> [Fri, 19 May 2023 14:49:50 +0200] rev 50524
stream-clone: introduce the notion of an experimental "v3" version
We introduce a new experimental "v3" stream protocol, disabled by default. In
practice the "v3-exp" protocol introduced in this changeset is identical to v2,
but this changeset, lay the groundwork for having a new protocol:
configuration, capability exchange, test coverage, etc.
The actual protocol work will starts in the coming changesets.
Pierre-Yves David <pierre-yves.david@octobus.net> [Sat, 20 May 2023 01:39:13 +0200] rev 50523
stream-clone: check is a compatible protocol can be found
The previous code was explicitly checking if "v2" is listed in the "stream"
bundle2 capability. The new code is checking is there is anything common
between the versions supported client side and server side overlaps.
This prepare the introduction of more stream version than "v2".
Pierre-Yves David <pierre-yves.david@octobus.net> [Sat, 20 May 2023 01:22:49 +0200] rev 50522
stream-clone: bail-out earlier if stream clone is not requested
The `canperformstreamclone` function is bit messy. However it seems clearer to
me to check if a stream-clone have been requested by the client or the server
at all, before checking if a compatible protocol can be negotiated with the
server.
So I am doing some gratuitous movement so reorder conditional.
Pierre-Yves David <pierre-yves.david@octobus.net> [Sat, 20 May 2023 01:19:26 +0200] rev 50521
stream-clone: bail-out earlier if pull is partial
The `canperformstreamclone` function is bit messy. However it seems clearer to
me to process the very generic condition about "can we consider a stream-clone
at all", before checking if a stream-clone is requested and if a compatible
protocol can be negotiated with the server.
So I am doing some gratuitous movement so reorder conditional.
Pierre-Yves David <pierre-yves.david@octobus.net> [Sat, 20 May 2023 01:17:27 +0200] rev 50520
stream-clone: bail-out earlier if destination repo is not empty
The `canperformstreamclone` function is bit messy. However it seems clearer to
me to process the very generic condition about "can we consider a stream-clone
at all", before checking if a stream-clone is requested and if a compatible
protocol can be negotiated with the server.
So I am doing some gratuitous movement so reorder conditional.
Arseniy Alekseyev <aalekseyev@janestreet.com> [Sun, 21 May 2023 00:00:57 +0200] rev 50519
stream-clone: check the version of streaming clone supported by the client
Make the server refuse to produce streaming clone bundle, if the client
doesn't specify the stream=v2 capability.
This is in preparation to introduce stream=v3.
As far as I can tell, this capability was added at the same time as
support for bundle2-based streaming pulls was added, so I don't expect
clients to break. (the modern client doesn't break, at any rate)
Pierre-Yves David <pierre-yves.david@octobus.net> [Sun, 21 May 2023 01:03:19 +0200] rev 50518
stream-clone: make sure the `stream` capability is set when bundling
This is important to start narrowing protocol option in the next changesets.
Arseniy Alekseyev <aalekseyev@janestreet.com> [Sun, 21 May 2023 00:00:29 +0200] rev 50517
stream-clone: upgrade the error message for bad stream request
The new version if more compact and more consistent with the general Mercurial
usage.
Pierre-Yves David <pierre-yves.david@octobus.net> [Sun, 21 May 2023 03:21:00 +0200] rev 50516
stream-clone: yield cache entry in `_entries_walk` too
The new function now cover the same ground as _v2_walk.
Pierre-Yves David <pierre-yves.david@octobus.net> [Sun, 21 May 2023 03:10:59 +0200] rev 50515
stream-clone: introduce a _entries_walk
That function insert itself between the store and `_v2_walk`. It only deals with
StoreEntry unlike `_v2_walk` that deal with actual file.
A share of the `_v2_walk` logic will be moved in this new `_entry_walk`
function. Having this function will help us to implement a new "v3" version of
the protocol that will be more entry centric.
Pierre-Yves David <pierre-yves.david@octobus.net> [Sun, 21 May 2023 02:29:33 +0200] rev 50514
store: make `walk` return an entry for obsolescence if requested so
Instead of having dedicated code in the streamclone code, we should have the
store deal with advertising the data it contains.
Pierre-Yves David <pierre-yves.david@octobus.net> [Sun, 21 May 2023 02:16:24 +0200] rev 50513
store: yield phases before changelog
Creating the `changelog.i` file make the repository usable, so dealing with phase earlier seems better.
Pierre-Yves David <pierre-yves.david@octobus.net> [Sun, 21 May 2023 02:15:04 +0200] rev 50512
store: make `walk` return an entry for phase if requested so
Instead of having dedicated code in the streamclone code, we should have the
store deal with advertising the data it contains.
Arseniy Alekseyev <aalekseyev@janestreet.com> [Mon, 22 May 2023 10:20:24 +0100] rev 50511
cli: add a test of `hg debugnodemap --manifest`
this is a new option that's not tested yet
Arseniy Alekseyev <aalekseyev@janestreet.com> [Thu, 18 May 2023 19:37:12 +0100] rev 50510
cli: fix spelling in `debugnodemap` error messages